Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MojoAsyncCaller doesn't sleep during retry #295

Closed
leonerd opened this issue Nov 5, 2018 · 1 comment
Closed

MojoAsyncCaller doesn't sleep during retry #295

leonerd opened this issue Nov 5, 2018 · 1 comment

Comments

@leonerd
Copy link
Contributor

leonerd commented Nov 5, 2018

The code is commented-out:

https://github.com/pplu/aws-sdk-perl/blob/f4073b2595335f46485a9c8f1197209434a02445/lib/Paws/Net/MojoAsyncCaller.pm#L32-36

It was added in this commit, which says "retry is pending" but hasn't been adjusted since:
9210512

(I'm intending to fix this, so this Issue is more of a placeholder for me to be working with)
@leonerd leonerd mentioned this issue Nov 5, 2018
Closed
pplu added a commit that referenced this issue Nov 12, 2018
@pplu
Merge pull request #300 from leonerd/issue-295
a542965 
Fix the implementation of retry sleep in MojoAsyncCaller (fixes #295)
@leonerd
Copy link
Contributor Author

leonerd commented Nov 19, 2018

With #300 being merged, this issue is now fixed. Thanks.

@leonerd leonerd closed this as completed Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leonerd