Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pppd: defaultroute6 is not frequent option and should not be used #257

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

pali
Copy link
Contributor

@pali pali commented Feb 22, 2021

In pppd.8 manpage move defaultroute6 option from FREQUENTLY USED OPTIONS
into OPTIONS and add a warning that this option should not be needed or
used on IPv6 networks. Option defaultroute6 is needed only for broken IPv6
networks. Also add nodefaultroute6 into sample options file.

In pppd.8 manpage move defaultroute6 option from FREQUENTLY USED OPTIONS
into OPTIONS and add a warning that this option should not be needed or
used on IPv6 networks. Option defaultroute6 is needed only for broken IPv6
networks. Also add nodefaultroute6 into sample options file.

Signed-off-by: Pali Rohár <pali@kernel.org>
@paulusmack paulusmack merged commit c312019 into ppp-project:master Feb 26, 2021
@ghost
Copy link

ghost commented Feb 27, 2021

Excuse my ignorance. I use pppd in openwrt and i noticed that with the latest release pppd started to write the routing table. I stumbled upon this. If nodefaultroute6 should not be needed, should it then not be a default. If true then why is nodefaultroute6 explicitly set in sample/config indicating that it is not a default? Should defaults not be commented out in configs instead?

@pali pali deleted the defaultroute6 branch February 27, 2021 14:57
@pali
Copy link
Contributor Author

pali commented Feb 27, 2021

@doverride: Seems that in your post you are confused with nodefaultroute6 and defaultroute6. I think it is documented in manual page cleanly. If nodefaultroute6 is specified (e.g. in config file) then defaultroute6 option is privileged operation. So ordinary non-root users cannot use defaultroute6 option. By default both nodefaultroute6 and defaultroute6 options are disabled, meaning that defaultroute6 is not privileged operation and that by default pppd does not insert default ipv6 device route. And in sample option file is specified nodefaultroute6 as it is safe default to prevent ordinary non-root users to use defaultroute6 option. Is it clear now?

@ghost
Copy link

ghost commented Feb 27, 2021 via email

@pali
Copy link
Contributor Author

pali commented Feb 27, 2021

Still wondering why all of a sudden pppd write the routing table with latest release

Maybe some another OpenWRT patch which can be harmful in some situation? Or does it happens also with upstream pppd without any custom patches?

@ghost
Copy link

ghost commented Feb 27, 2021 via email

@Neustradamus
Copy link
Member

@hauke, please read the talk from @doverride here, it is linked to OpenWrt.

@hauke
Copy link

hauke commented Feb 28, 2021

@doverride between which version did you see the changed behavior?
did it change after this commit openwrt/openwrt@030bc39 or do you compare OpenWrt 19.07 with master or something similar?

@ghost
Copy link

ghost commented Feb 28, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants