Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransformSequence.Loop() is broken for instantaneous transforms #1577

Closed
smoogipoo opened this issue May 30, 2018 · 2 comments
Closed

TransformSequence.Loop() is broken for instantaneous transforms #1577

smoogipoo opened this issue May 30, 2018 · 2 comments

Comments

@smoogipoo
Copy link
Contributor

smoogipoo commented May 30, 2018

Currently, instantaneous transforms are updated instantly when they're added to the target Drawable. This occurs before IsLooping is set, and results in the transform being immediately removed from the target.

This is not intended for some transforms, e.g. Spin() which rely on the instantaneous transform being looped.

The following is an easily replicable case:

box.MoveToX(100)
      .Then().Delay(1000).MoveToX(0)
      .Then().MoveToX(200, 1000).Loop();

Which result in the following:

Time Expected-X Actual-X Comment
0 100 100
999 100 100
1000 0 0
1999 ~200 ~200
2000 100 200 New loop starts
2999 100 200
3000 0 0
3999 ~200 ~200
4000 100 200 New loop starts

expected vs actual

Haven't been able to completely resolve this issue yet.

@benpigchu
Copy link

Seems this was actually fixed in #1580

@peppy
Copy link
Sponsor Member

peppy commented Jun 25, 2018

It indeed was!

@peppy peppy closed this as completed Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants