Draw size preserving fill container #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrawSizePreservingFillContainer allows filling the parent while enforcing a given TargetDrawSize. This is useful, for example, to automatically scale the user interface according to the window resolution, or to provide automatic HiDPI display support.
peppy
reviewed
Oct 12, 2017
| using osu.Framework.Platform; | ||
| using osu.Framework.Testing; | ||
|
|
||
| namespace osu.Framework.Tests | ||
| { | ||
| internal class VisualTestGame : TestGame | ||
| internal class VisualTestGame : Game |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
smoogipoo
requested changes
Oct 12, 2017
| break; | ||
|
|
||
| case DrawSizePreservationStrategy.Maximum: | ||
| Scale = new Vector2(Math.Min(drawSizeRatio.X, drawSizeRatio.Y)); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| break; | ||
| } | ||
|
|
||
|
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
1 task
smoogipoo
approved these changes
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
DrawSizePreservingFillContaineras a generalization ofRatioAdjustfrom https://github.com/ppy/osu . Once this is merged in, ppy/osu#1359 removesRatioAdjustand replaces it with this.Further, this PR uses
DrawSizePreservingFillContainerwithinVisualTestGameto make the tests usable on HiDPI screens.