Add method to transform a Transformable to a point in time #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Tom94
reviewed
Nov 9, 2017
| /// Whether a parent is allowed to clear this <see cref="Transformable"/>'s <see cref="Transform"/>s | ||
| /// through <see cref="ClearTransforms(bool, string)"/> and <see cref="ClearTransformsAfter(double, bool)"/>. | ||
| /// </summary> | ||
| protected internal virtual bool AllowTransformClearByParent => true; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Tom94
reviewed
Nov 9, 2017
| if (c.AllowTransformClearByParent) | ||
| continue; | ||
| c.ClearTransforms(true, targetMember); | ||
| } |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Tom94
reviewed
Nov 9, 2017
| if (transforms[i].StartTime < time) | ||
| break; | ||
| transforms.RemoveAt(i); | ||
| } |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Tom94
reviewed
Nov 9, 2017
| /// </summary> | ||
| /// <param name="time">The time to clear <see cref="Transform"/>s after.</param> | ||
| /// <param name="propagateChildren">Whether to also clear such <see cref="Transform"/>s of children.</param> | ||
| public virtual void ClearTransformsAfter(double time, bool propagateChildren = false) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Tom94
reviewed
Nov 9, 2017
| } | ||
| } | ||
|
|
||
| public override void TransformStateTo(double time, bool propagateChildren = false) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Tom94
reviewed
Nov 9, 2017
| } | ||
|
|
||
| public override void TransformStateTo(double time, bool propagateChildren = false) | ||
| { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Tom94
approved these changes
Nov 10, 2017
peppy
approved these changes
Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #osu-client.