Improve performance of DrawVisualiser #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it would iterate over every container and perform a FirstOrDefault. This caused severe slowdowns in DrawVisualiser. With this,
peppy
approved these changes
Nov 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it would iterate over every container and perform a FirstOrDefault on it to figure out whether a VisualisedDrawable existed/should be updated. With many drawables, this was super expensive, tending towards O(n^2) in worst case, plus other O(n) loops over visualised drawables.
I noticed this as a hot line when profiling:
This changes makes DrawVisualiser instead respond to additions/removal from AliveInternalChildren, and caches the VisualisedDrawables, removing the need for expiry/reconstruction and more O(n) searching.
Along with this, these changes also seem to fix the flickering present due to the expiries inside VisualisedDrawable, such as in the case of TestCaseBlending.