Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TabbableContainer ignoring children of CompositeDrawables #1150

Merged
merged 3 commits into from
Nov 11, 2017

Conversation

default0
Copy link
Contributor

@default0 default0 commented Nov 11, 2017

What it sounds like. If you had a hierarchy like this:

Container
|-> CompositeDrawable
     |-> TextBox (TabbableContentContainer set to Container)
|-> CompositeDrawable
     |-> TextBox (TabbableContentContainer set to Container)

Then tabbing between the TextBoxes would not work, because they are both children of a CompositeDrawable. This is fixed by checking through all children of all CompositeDrawables, instead of only of Containers when figuring out which control to transfer focus to when tabbing.

@peppy peppy merged commit 6cffc37 into ppy:master Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants