Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a better method to retrieve platform-specific information #1218

Merged
merged 2 commits into from Dec 1, 2017
Merged

Add a better method to retrieve platform-specific information #1218

merged 2 commits into from Dec 1, 2017

Conversation

smoogipoo
Copy link
Contributor

✓ Cross platform (.NET Core compatible)
✓ No uname issues with debugging
✓ No more relying on magic constants defined by mono (6 is a recent addition for osx)

@smoogipoo
Copy link
Contributor Author

We can eventually retrieve mobile platforms using arm/arm64 architectures.

@peppy peppy merged commit d231ca9 into ppy:master Dec 1, 2017
jorolf
jorolf reviewed Dec 2, 2017
View reviewed changes
osu.Framework/RuntimeInfo.cs
IsMacOsx = true;
else if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux))
IsLinux = true;
IsUnix = IsMacOsx || IsUnix;

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

Tom94
Tom94 reviewed Dec 2, 2017
View reviewed changes
osu.Framework/RuntimeInfo.cs
IsUnix = p == 4 || p == 6 || p == 128;
IsWindows = Path.DirectorySeparatorChar == '\\';
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
IsWindows = true;

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@smoogipoo smoogipoo deleted the better-runtimeinfo branch February 22, 2018 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy approved these changes

@Tom94 Tom94 Tom94 left review comments

@jorolf jorolf jorolf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smoogipoo @peppy @Tom94 @jorolf