Populate HandleInput

osu.Framework.Tests/Visual/TestCaseDrawablePath.cs

@@ -105,8 +105,6 @@ public TestCaseDrawablePath() : base(2, 2)
 
         private class UserDrawnPath : Path
         {
-            public override bool HandleInput => true;
-
             private Vector2 oldPos;
 
             protected override bool OnDragStart(InputState state)

osu.Framework.Tests/Visual/TestCaseInputResampler.cs

@@ -183,8 +183,6 @@ public ArcPath(bool raw, bool keepFraction, InputResampler inputResampler, Textu
 
         private class UserDrawnPath : SmoothedPath
         {
-            public override bool HandleInput => true;
-
             public SpriteText DrawText;
 
             protected virtual void AddUserVertex(Vector2 v) => AddRawVertex(v);

osu.Framework.Tests/Visual/TestCaseTriangles.cs

@@ -172,7 +172,6 @@ private void addCornerMarkers(Container box, int size = 50, Color4? colour = nul
     internal class DraggableTriangle : Triangle
     {
         public bool AllowDrag = true;
-        public override bool HandleInput => true;
 
         protected override bool OnDrag(InputState state)
         {

osu.Framework/Caching/HandleInputCache.cs

@@ -0,0 +1,57 @@
+// Copyright (c) 2007-2017 ppy Pty Ltd <contact@ppy.sh>.
+// Licensed under the MIT Licence - https://raw.githubusercontent.com/ppy/osu-framework/master/LICENCE
+
+using System;
+using System.Collections.Concurrent;
+using System.Reflection;
+using osu.Framework.Graphics;
+
+namespace osu.Framework.Caching
+{
+    public class HandleInputCache
+    {
+        private readonly ConcurrentDictionary<Type, bool> cachedValues = new ConcurrentDictionary<Type, bool>();
+
+        private readonly string[] inputMethods = {
+            "OnHover",
+            "OnHoverLost",
+            "OnMouseDown",
+            "OnMouseUp",
+            "OnClick",
+            "OnDoubleClick",
+            "OnDragStart",
+            "OnDrag",
+            "OnDragEnd",
+            "OnWheel",
+            "OnFocus",
+            "OnFocusLost",
+            "OnKeyDown",
+            "OnKeyUp",
+            "OnMouseMove"
+        };
+
+        public bool Get(Type type)
+        {
+            if (!type.IsSubclassOf(typeof(Drawable)))
+                throw new ArgumentException();
+
+            var cached = cachedValues.TryGetValue(type, out var value);
+
+            if (!cached)
+            {
+                foreach (var inputMethod in inputMethods)
+                {
+                    var isOverridden = type.GetMethod(inputMethod, BindingFlags.Instance | BindingFlags.NonPublic).DeclaringType != typeof(Drawable);
+                    if (isOverridden)
+                    {
+                        cachedValues.TryAdd(type, true);
+                        return true;
+                    }
+                }
+                cachedValues.TryAdd(type, value = false);
+            }
+
+            return value;
+        }
+    }
+}

osu.Framework/Graphics/Containers/TextFlowContainer.cs

@@ -118,8 +118,6 @@ public string Text
             }
         }
 
-        public override bool HandleInput => false;
-
         public override bool Invalidate(Invalidation invalidation = Invalidation.All, Drawable source = null, bool shallPropagate = true)
         {
             if ((invalidation & Invalidation.DrawSize) > 0)

osu.Framework/Graphics/Drawable.cs

@@ -206,6 +206,12 @@ internal void Load(IFrameBasedClock clock, IReadOnlyDependencyContainer dependen
             }
         }
 
+        [BackgroundDependencyLoader]
+        private void load(HandleInputCache handleInputCache)
+        {
+            this.handleInputCache = handleInputCache;
+        }
+
         /// <summary>
         /// Runs once on the update thread after loading has finished.
         /// </summary>
@@ -1830,10 +1836,12 @@ protected virtual void OnFocusLost(InputState state)
         /// is propagated up the scene graph to the next eligible Drawable.</returns>
         protected virtual bool OnMouseMove(InputState state) => false;
 
+        private HandleInputCache handleInputCache;
+
         /// <summary>
         /// This drawable only receives input events if HandleInput is true.
         /// </summary>
-        public virtual bool HandleInput => false;
+        public virtual bool HandleInput => handleInputCache.Get(GetType());
 
         /// <summary>
         /// Check whether we have active focus.

osu.Framework/Graphics/Performance/FrameStatisticsDisplay.cs

@@ -482,8 +482,6 @@ public TimeBar(TextureAtlas atlas)
 
                 Sprite.Texture = atlas.Add(WIDTH, HEIGHT);
             }
-
-            public override bool HandleInput => false;
         }
 
         private class CounterBar : Container

osu.Framework/Graphics/Sprites/SpriteText.cs

@@ -22,7 +22,7 @@ namespace osu.Framework.Graphics.Sprites
     /// </summary>
     public class SpriteText : FillFlowContainer, IHasCurrentValue<string>, IHasLineBaseHeight, IHasText, IHasFilterTerms
     {
-        public IEnumerable<string> FilterTerms => new [] { Text };
+        public IEnumerable<string> FilterTerms => new[] { Text };
 
         private static readonly char[] default_fixed_width_exceptions = { '.', ':', ',' };
 
@@ -121,8 +121,6 @@ public float LineBaseHeight
 
         private FontStore store;
 
-        public override bool HandleInput => false;
-
         /// <summary>
         /// Creates a new sprite text. <see cref="Container{T}.AutoSizeAxes"/> is set to <see cref="Axes.Both"/> by default.
         /// </summary>

osu.Framework/Graphics/Visualisation/LogOverlay.cs

@@ -145,8 +145,6 @@ internal class DrawableLogEntry : Container
 
         private const float font_size = 14;
 
-        public override bool HandleInput => false;
-
         public DrawableLogEntry(LogEntry entry)
         {
             RelativeSizeAxes = Axes.X;

osu.Framework/Platform/GameHost.cs

@@ -14,6 +14,7 @@
 using OpenTK.Graphics.ES30;
 using OpenTK.Input;
 using osu.Framework.Allocation;
+using osu.Framework.Caching;
 using osu.Framework.Configuration;
 using osu.Framework.Extensions.IEnumerableExtensions;
 using osu.Framework.Graphics;
@@ -157,6 +158,7 @@ protected GameHost(string gameName = @"")
 
             Dependencies.Cache(this);
             Dependencies.Cache(Storage = GetStorage(gameName));
+            prepareHandleInputCache();
 
             Name = gameName;
             Logger.GameIdentifier = gameName;
@@ -180,6 +182,18 @@ protected GameHost(string gameName = @"")
                 Environment.CurrentDirectory = path;
         }
 
+        private void prepareHandleInputCache()
+        {
+            var handleInputCache = new HandleInputCache();
+
+            foreach (var type in AppDomain.CurrentDomain.GetAssemblies().SelectMany(a => a.GetTypes()).Where(t => t.IsSubclassOf(typeof(Drawable))))
+            {
+                handleInputCache.Get(type);
+            }
+
+            Dependencies.Cache(handleInputCache);
+        }
+
         private void exceptionHandler(object sender, UnhandledExceptionEventArgs e)
         {
             var exception = (Exception)e.ExceptionObject;

osu.Framework/osu.Framework.csproj

@@ -192,6 +192,7 @@
     <Compile Include="Graphics\Cursor\CursorEffectContainer.cs" />
     <Compile Include="Graphics\Cursor\IHasCustomTooltip.cs" />
     <Compile Include="Graphics\Cursor\ITooltip.cs" />
+    <Compile Include="Caching\HandleInputCache.cs" />
     <Compile Include="Graphics\Primitives\RectangleI.cs" />
     <Compile Include="Graphics\Primitives\Vector2I.cs" />
     <Compile Include="Graphics\Shapes\Circle.cs" />