Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements to textbox input #1394

Merged
merged 5 commits into from Feb 15, 2018
Merged

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Feb 15, 2018

  • Fixes TextBoxes blocking all key input.
    • Not entirely sure why this was here, if any case comes up where this breaks we'll analyse it/comment it appropriately.
  • Removes unnecessary returns which are already handled in OnAction.
  • Fixes PlatformActions not being handled before keys.
    • Fixes not being able to Cmd+Left/Cmd+Right in the search box in SongSelect.
  • Fixes readonly textboxes being able to be tabbed to. Browsers do the same thing.

@smoogipoo smoogipoo added this to the February 2018 milestone Feb 15, 2018
@peppy
Copy link
Sponsor Member

peppy commented Feb 15, 2018

Breaks song select left/right arrows.

@peppy
Copy link
Sponsor Member

peppy commented Feb 15, 2018

Correction: breaks left/right arrow keys game-wide (slider bars don't work, for instance). I think this is related to the priority change.

@UselessToucan
Copy link
Contributor

I think you should merge #1365 and #1362 before working on this PR because it will allow you to see how everything fits together.

@peppy
Copy link
Sponsor Member

peppy commented Feb 15, 2018

We generally merge required fixes before breaking changes.

@smoogipoo
Copy link
Contributor Author

The reason why I did this is to fix the behaviour in those PRs prior to merging them. They're my target but there are a few interactions and quirks with input handling before those can be merged.

Focus is one last thing remaining before those two can be merged.

@peppy peppy merged commit 458ebc2 into ppy:master Feb 15, 2018
@smoogipoo smoogipoo deleted the textbox-fixes branch February 22, 2018 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants