New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly define the dynamic compilation namespace to avoid crosstalk #1499

Merged
merged 1 commit into from Apr 6, 2018

Conversation

2 participants
@peppy
Member

peppy commented Apr 6, 2018

The old method was using one global namespace across all projects, incorrectly giving osu.Game access to osu.Framework internals.

Explicitly define the dynamic compilation namespace to avoid crosstalk
The old method was using one global namespace across all projects, incorrectly giving `osu.Game` access to `osu.Framework` internals.

@peppy peppy added this to the April 2018 milestone Apr 6, 2018

@peppy peppy added the testing label Apr 6, 2018

@peppy peppy referenced this pull request Apr 6, 2018

Merged

Update AssemblyInfo in line with framework changes #2353

1 of 1 task complete

@smoogipoo smoogipoo merged commit 02d7a0f into ppy:master Apr 6, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:dynamic-compilation-override-fix branch Apr 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment