New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize line endings to LF #1509

Merged
merged 2 commits into from Apr 13, 2018

Conversation

3 participants
@peppy
Member

peppy commented Apr 11, 2018

We probably want to do this. Unfortunately it's going to rewrite a lot of files, but kind of unavoidable.

  • Switches to applying line endings on checkout.
  • Uses CRLF for c# files for now, although this if likely not needed if users set autocrlf correctly.

Should have no effect on existing PRs (have already tested a merge).

References: https://help.github.com/articles/dealing-with-line-endings/ and boogie-org/boogie#15

@peppy peppy added the code quality label Apr 11, 2018

@peppy peppy added this to the Candidate Issues milestone Apr 11, 2018

.gitignore text eol=lf
.gitattributes text eol=lf
*.md text eol=lf
.travis.yml text eol=lf

This comment has been minimized.

@Tom94

Tom94 Apr 11, 2018

Collaborator

Did you intentionally drop the binary-marked file formats?

This comment has been minimized.

@peppy

peppy Apr 11, 2018

Member

They didn't seem to be necessary, but I'm happy to add them back if it makes you feel more safe. I think generally git is smart enough to discern these on its own (.mp3 and .png weren't in there, for instance, but both got detected correctly).

@smoogipoo

This comment has been minimized.

Contributor

smoogipoo commented Apr 13, 2018

Lets do this

@smoogipoo smoogipoo merged commit b034486 into ppy:master Apr 13, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:fix-line-endings branch Apr 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment