Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize line endings to LF #1509

Merged
merged 2 commits into from
Apr 13, 2018
Merged

Normalize line endings to LF #1509

merged 2 commits into from
Apr 13, 2018

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Apr 11, 2018

We probably want to do this. Unfortunately it's going to rewrite a lot of files, but kind of unavoidable.

  • Switches to applying line endings on checkout.
  • Uses CRLF for c# files for now, although this if likely not needed if users set autocrlf correctly.

Should have no effect on existing PRs (have already tested a merge).

References: https://help.github.com/articles/dealing-with-line-endings/ and boogie-org/boogie#15

@peppy peppy added this to the Candidate Issues milestone Apr 11, 2018
.gitignore text eol=lf
.gitattributes text eol=lf
*.md text eol=lf
.travis.yml text eol=lf

This comment was marked as off-topic.

This comment was marked as off-topic.

@smoogipoo
Copy link
Contributor

Lets do this

@smoogipoo smoogipoo merged commit b034486 into ppy:master Apr 13, 2018
@peppy peppy deleted the fix-line-endings branch April 18, 2018 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants