Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to project files using Directory.Build.props #1566

Merged
merged 3 commits into from
May 28, 2018

Conversation

huoyaoyuan
Copy link
Contributor

I'm working on my own project these days, and found some noticeable things.

The special name Directory.Build.props will be automatically imported by latest MSBuild.
Common property file should use relative path from itself.
The service guid is for unit test, so it's sure to keep it only in test project. (If ci is happy for this)

Justification:

Should latest language version be introduced? C# releases minor versions rapidly now, and third-party tools may not understand it, especially for non-Visual Studio users.
But C# 7.x has improved some performance (span and readonly struct), making minor version update worth while.

Roslyn team is interested in enforcing code style at build time. Should I introduce rules in editor config now?

peppy
peppy previously approved these changes May 25, 2018
@peppy peppy requested a review from smoogipoo May 25, 2018 01:35
@peppy peppy changed the title Slightly standardize project files. Improvement to project files using Directory.Build.props May 25, 2018
@peppy peppy added this to the May 2018 milestone May 25, 2018
@@ -1,10 +1,10 @@
<!-- Contains required properties for osu!framework projects. -->
<Project>
<PropertyGroup Label="C#">
<LangVersion>7</LangVersion>
<LangVersion>7.3</LangVersion>

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@smoogipoo
Copy link
Contributor

I don't know if we'll be using roslyn analysers going forward, they need more discussion. 👎 for now.

@smoogipoo
Copy link
Contributor

Cool stuff

@smoogipoo smoogipoo merged commit e8beb25 into ppy:master May 28, 2018
@huoyaoyuan huoyaoyuan deleted the project-system branch May 28, 2018 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants