Adds missing AutoSize invalidation definition, Fixes FlowContainer layout regression #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ched autoSize vector
|
While this may fix the issue, it's likely not a correct fix. This should not be required as we should only need to care about InvalidateFromChild (just below your addition) in the case of AutoSize. |
|
As per extended discussion in discord, this is likely not what we want. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to invalidate cached
autoSizevectorFixes #174
This bug is most prominent in
FlowContainers, but actually appears to stem fromAutoSizeContainer(their parent)'sautoSizevector not being invalidated correctly/at all from non-child Invalidate calls.