Stop exposing TrackBass's constructor
#4873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale is that it can no longer work without being in the audio hierarchy. A `TrackStore` should be used instead.
peppy
added a commit
to peppy/osu
that referenced
this pull request
Nov 9, 2021
This paves the way for the framework code quality change (ppy/osu-framework#4873) which stops exposing the constructor. Most of the restructuring here is required to give `PreviewTrackManager` an adjustable target to apply the global mute.
peppy
added a commit
to peppy/osu
that referenced
this pull request
Nov 9, 2021
This paves the way for the framework code quality change (ppy/osu-framework#4873) which stops exposing the constructor. Most of the restructuring here is required to give `PreviewTrackManager` an adjustable target to apply the global mute.
smoogipoo
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale is that it can no longer work without being in the audio hierarchy. A
TrackStoreshould be used instead.Note that I am still working on the osu!-side changes to support this. Will block until I'm 100%.
PreviewTrackManagerto avoid constructingTrackBasslocally osu#15535TrackBassmanually will throw on first usage #4813