Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix texture bind early return bypassing glActiveTexture() #5001

Merged
merged 2 commits into from Jan 25, 2022
Merged

Fix texture bind early return bypassing glActiveTexture() #5001

merged 2 commits into from Jan 25, 2022

Conversation

smoogipoo
Copy link
Contributor

Fixes #5000

The most simple fix because I don't expect performance to be impacted as a result of potentially one redundant glBindTexture call.

@smoogipoo smoogipoo mentioned this pull request Jan 25, 2022
Closed
@peppy peppy enabled auto-merge January 25, 2022 04:48
@peppy peppy disabled auto-merge January 25, 2022 04:48
@peppy peppy enabled auto-merge January 25, 2022 05:05
@peppy peppy merged commit c689797 into ppy:master Jan 25, 2022
@smoogipoo smoogipoo deleted the fix-active-texture branch September 11, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy approved these changes

Assignees
No one assigned
Labels
area:graphics size/S type:reliability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GLWrapper.BindTexture() behavior can lead to incorrect assumptions.
2 participants
@smoogipoo @peppy