Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for configurable deadzone for joystick/gamepad #5122

Merged
merged 4 commits into from
Apr 23, 2022
Merged

Add support for configurable deadzone for joystick/gamepad #5122

merged 4 commits into from
Apr 23, 2022

Conversation

maromalo
Copy link
Contributor

Makes deadzone_threshold bindable to allow it to be changed. Copied from MouseHandler.Sensitivity.

frenzibyte
frenzibyte requested changes Apr 23, 2022
View reviewed changes
Copy link
Member

@frenzibyte frenzibyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

Does this come with an osu!-side implementation for user access to this setting?

osu.Framework/Input/Handlers/Joystick/JoystickHandler.cs Outdated Show resolved Hide resolved
osu.Framework/Input/Handlers/Joystick/JoystickHandler.cs Outdated Show resolved Hide resolved
@maromalo
Copy link
Contributor Author

Thanks for the contribution.

Does this come with an osu!-side implementation for user access to this setting?

Yes, figured I should pull the framework-side first.

@peppy peppy enabled auto-merge April 23, 2022 02:50
@peppy peppy merged commit 9d02fea into ppy:master Apr 23, 2022
@maromalo maromalo mentioned this pull request Apr 23, 2022
Merged
2 tasks
@maromalo maromalo mentioned this pull request May 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy approved these changes

@frenzibyte frenzibyte frenzibyte approved these changes

Assignees
No one assigned
Labels
area:input size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maromalo @peppy @frenzibyte