Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable NRT on IHasCustomTooltip interface #5260

Merged
merged 1 commit into from Jun 23, 2022
Merged

Enable NRT on IHasCustomTooltip interface #5260

merged 1 commit into from Jun 23, 2022

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Jun 23, 2022

Probably should be applied to all interfaces asap as it leads to weirdness in usages otherwise.

smoogipoo
smoogipoo approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay. Not sure about the : class specification but that seems to be because we're on an older C# lang version.

@smoogipoo smoogipoo enabled auto-merge June 23, 2022 08:35
@smoogipoo smoogipoo merged commit 00df52d into ppy:master Jun 23, 2022
This was referenced Jun 28, 2022
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees
No one assigned
Labels
size/XS type:code-quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peppy @smoogipoo @bdach