Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix all remaining OpenGL-specific classes with "GL" in name #5381

Merged
merged 4 commits into from
Aug 26, 2022

Conversation

frenzibyte
Copy link
Member

@frenzibyte frenzibyte commented Aug 25, 2022

First steps towards supporting Veldrid, need to have all OpenGL-specific classes prefixed with GL to not conflict in names with the upcoming Veldrid variants. Few notes:

  • GLLinear{Buffer,Batch} reads a bit weird given the double L in the name, but not sure if it should be renamed.
  • VideoTexture has been renamed to VideoTextuerGL and also been moved to the OpenGL.Textures namespace, instead of its original place (Videos).
  • IVertexBuffer has also been prefixed as it's currently internal and OpenGL-specific, but it could potentially be moved out if we decide to have a base Renderer/VertexBatch class which makes use of this interface.

@peppy
Copy link
Sponsor Member

peppy commented Aug 26, 2022

I'd prefer GL rather than OpenGL for brevity. Also optionally, it could be a suffix in all cases similar to VideoTextureGL. Need more opinions on that.

@frenzibyte
Copy link
Member Author

frenzibyte commented Aug 26, 2022

I was under the thought that the “GL” suffix was used to indicate that the class isn’t directly an inheritor of an interface/class with the same name (i.e. TextureGL looks like it’s own class, while GLTexture/OpenGLTexture sounds like it inherits from Texture).

Bit of a weak argument though, and I’ve already opted to call the Veldrid one as VeldridTexture rather than TextureVd anyways.

@smoogipoo
Copy link
Contributor

“GL” suffix was used to indicate that the class isn’t directly an inheritor

There's nothing special about the naming. I agree with using "GL".

Also optionally, it could be a suffix

Hmm. We typically don't suffix things in o!f/lazer, as opposed to stable. Between VertexBufferVeldrid/VertexBufferVd and VeldridVertexBuffer/VdVertexBuffer, I think I prefer the latter.

@peppy
Copy link
Sponsor Member

peppy commented Aug 26, 2022

Prefix is fine. "Vd" feels weird so I'd prefer using "Veldrid".

@frenzibyte frenzibyte changed the title Prefix all remaining OpenGL-specific classes with "OpenGL" in name Prefix all remaining OpenGL-specific classes with "GL" in name Aug 26, 2022
peppy
peppy previously approved these changes Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants