Fix directory selector crashing when attempting to display a bitlocker locked drive #5478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r locked drive Closes ppy#5477. Untested.
smoogipoo
approved these changes
Oct 24, 2022
|
Should probably display this error somewhere/give the error somewhere for a consumer to handle and display it, but probably fine for now? |
|
Can't test the exact scenario on my windows install because it can't into bitlocker but I can't imagine this not fixing it. I suggested logging the error in the issue, but I think no logging is fine, given that |
bdach
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested.