Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Renderer holding a permanent reference to every texture ever created #5493

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Fix Renderer holding a permanent reference to every texture ever created #5493

merged 2 commits into from
Oct 28, 2022

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Oct 28, 2022

Closes #5486.

smoogipoo
smoogipoo requested changes Oct 28, 2022
View reviewed changes
osu.Framework/Graphics/Rendering/Dummy/DummyNativeTexture.cs Outdated
ulong INativeTexture.TotalBindCount
{
get => 0;
set => throw new System.NotImplementedException();
Copy link
Contributor

@smoogipoo smoogipoo Oct 28, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably shouldn't throw. Maybe { } instead, if it works?

Edit: or get; set; as per the other implementation

@pull-request-size pull-request-size bot added size/S and removed size/M labels Oct 28, 2022
@smoogipoo smoogipoo merged commit 3063360 into ppy:master Oct 28, 2022
@peppy peppy deleted the fix-texture-references branch November 7, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees
No one assigned
Labels
size/S type:performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Renderer holds references to all textures indefinitely
2 participants
@peppy @smoogipoo