Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external links not working on Android #5666

Merged
merged 4 commits into from Mar 6, 2023

Conversation

Joehuu
Copy link
Member

@Joehuu Joehuu commented Mar 4, 2023

@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 5, 2023
@bdach
Copy link
Collaborator

bdach commented Mar 5, 2023

Not sure how everybody else is feeling but for this one I tend to think we don't need to do the manifest merging thing we did in the game project and we can probably go with how things are right now. Rationale being that:

  • there is much less duplication here,
  • SampleGame.Android doesn't really need this change for anything as it's just a spinning box (so we may even want to revert that),
  • this is a "framework" project, so adding an overlay does nothing for consumers anyway. And if we had android template projects they couldn't use the overlay anyways (as they have to be self-contained).

@bdach bdach requested a review from Susko3 March 5, 2023 12:43
Susko3
Susko3 previously approved these changes Mar 5, 2023
Huge nit but feels a bit better as contact e-mail is used elsewhere
in tests already.
@bdach bdach enabled auto-merge March 6, 2023 20:14
@bdach bdach merged commit eac684a into ppy:master Mar 6, 2023
@Joehuu Joehuu deleted the fix-android-external-links branch March 6, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants