Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow SearchContainer implementations to manually trigger a Filter operation #5772

Merged
merged 8 commits into from
May 26, 2023
Merged

Allow SearchContainer implementations to manually trigger a Filter operation #5772

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3db738b
Add `Filter` method
Cootz May 6, 2023
017c939
Add xml doc
Cootz May 13, 2023
a38b67c
Merge branch 'master' into add-search-method-for-search-container
peppy May 25, 2023
e866121
Rewrite xmldoc
peppy May 25, 2023
73baf66
Add early return
Cootz May 26, 2023
635a855
Add back inline check for validity in `Update` method
peppy May 26, 2023
0e13221
Merge branch 'master' into add-search-method-for-search-container
peppy May 26, 2023
7e0ecb5
Merge branch 'master' into add-search-method-for-search-container
peppy May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions osu.Framework/Graphics/Containers/SearchContainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,7 @@ protected override void Update()
{
base.Update();

if (!filterValid.IsValid)
Filter();
Filter();
Cootz marked this conversation as resolved.
Show resolved Hide resolved
}

/// <summary>
Expand All @@ -104,9 +103,14 @@ protected override void Update()
///
/// However, if <see cref="SearchContainer{T}"/> or any of its parents are hidden this will not be run.
/// If an implementation relies on filtering to become present / visible, this method can be used to force a filter.
///
/// Note that this will only run if the current filter is not in an already valid state.
/// </remarks>
protected void Filter()
{
if (filterValid.IsValid)
return;

canBeShownBindables.Clear();
performFilter();
filterValid.Validate();
Expand Down