Update veldrid with macOS CVDisplayLink support
#5821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changes required from our end as we are already calling the relevant
Renderer.WaitUntilNextFrameReady()function. Veldrid side, this is now supported on desktop metal platforms.Closes #5803 (separate PR so we can keep that one around for potential reference – it contains iOS changes).
In the future, we can improve this further by implementing
CVDisplayLinkinMacOSWindow, in a very similar way to #5820. Once this is merged and all has settled, I'll open an issue to track that. The benefits would be that the timings are slightly more precise as we are not using a semaphore. Higher effort though, as we will need to figure a better solution for multi-threaded mode.