Fix performance when viewing the tail end of a long / zoomed-in waveform #5843
Conversation
| int startIndex = (int)Math.Clamp(localMaskingRectangle.Left / separation, 0, points.Count - 1); | ||
| int endIndex = (int)Math.Clamp(localMaskingRectangle.Right / separation + 1, 0, points.Count - 1); |
There was a problem hiding this comment.
The index choice here seems correct (visual inspection). Translating these from the original conditions gets a bit dicey with the < >, but it's also fine if we err on the side of caution and make them include one more on each side.
So if this comes up in review, it's fine to decrement / increment the start / end if required. But visually this does seem to be what we want. Maybe adjusting MaskingSmoothness in a masking scenario might require more?
There was a problem hiding this comment.
Looking at the maths this does appear to be correct to me. Doesn't seem like any adjustments are needed.
| int startIndex = (int)Math.Clamp(localMaskingRectangle.Left / separation, 0, points.Count - 1); | ||
| int endIndex = (int)Math.Clamp(localMaskingRectangle.Right / separation + 1, 0, points.Count - 1); |
There was a problem hiding this comment.
Looking at the maths this does appear to be correct to me. Doesn't seem like any adjustments are needed.
Removes mention of nonexistent assertion, and adds information about the other half of the precomputation.
Closes ppy/osu#23905