Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert masking SSBO changes #5990

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Revert masking SSBO changes #5990

merged 3 commits into from
Sep 14, 2023

Conversation

smoogipoo
Copy link
Contributor

Reverts:
#5960
#5952
#5987

Reverted:

  • Floating point scissor
  • MaskingInfo struct renamings
  • All the masking-related SSBO/shader changes

Not reverted because they may come in useful in the future:

  • A few improvements to VeldridShader/GLShader around resource indices
  • Addition of DrawRectangle to IDrawable
  • TestSceneScissor
  • ShaderStorageBufferObjectStack/IShaderStorageBufferObject and implementations.

@smoogipoo smoogipoo mentioned this pull request Sep 13, 2023
Merged
2 tasks
@bdach bdach self-requested a review September 14, 2023 05:30
@bdach
Copy link
Collaborator

bdach commented Sep 14, 2023

Diffing against a8a1f13, seems good to me.

@bdach bdach merged commit 5307515 into ppy:master Sep 14, 2023
17 of 21 checks passed
@bdach bdach changed the title Revert masking ssbo changes Revert masking SSBO changes Sep 14, 2023
@smoogipoo smoogipoo deleted the revert-masking-ssbo branch October 10, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdach bdach bdach approved these changes

Assignees
No one assigned
Labels
area:graphics size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smoogipoo @bdach