Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RectangleF for masking scissor #5960

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Use RectangleF for masking scissor #5960

merged 2 commits into from
Aug 21, 2023

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Aug 3, 2023 •
edited by peppy
Loading

Prereqs:

Fixes (at least some) 1px masking errors:

before after
osu_2023-08-03_16-05-01 osu_2023-08-03_16-05-38

@peppy peppy requested a review from bdach August 21, 2023 12:44
@bdach bdach merged commit 26b92b1 into ppy:master Aug 21, 2023
17 of 21 checks passed
@bdach bdach mentioned this pull request Sep 4, 2023
Open
@smoogipoo smoogipoo deleted the rectanglef-scissor branch September 11, 2023 02:25
smoogipoo added a commit to smoogipoo/osu-framework that referenced this pull request Sep 13, 2023
@smoogipoo
Revert "Merge pull request ppy#5960 from smoogipoo/rectanglef-scissor"
2cb2b16 
This reverts commit 26b92b1, reversing
changes made to 844a9ee.
@smoogipoo smoogipoo mentioned this pull request Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy approved these changes

@bdach bdach bdach approved these changes

Assignees
No one assigned
Labels
area:graphics size/S size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smoogipoo @peppy @bdach