Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WaveformGraph overhead when DrawPosition is changed #6009

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Fix WaveformGraph overhead when DrawPosition is changed #6009

merged 2 commits into from
Oct 2, 2023

Commits on Sep 29, 2023

  1. Fix WaveformGraph overhead when DrawPosition is changed 

    The previous attempt to fix this
(ppy#5197) helped, but there
were still some scenarios where invalidation would cause
regeneration.

Let's just do our own invalidation for now.

One thing I'm not sure about is whether checking `DrawSize` here is
enough (should I be using `ScreenSpaceDrawQuad.Size` instead?).
    @peppy
    peppy committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    de75632 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Fix typo in inline comment

    @bdach
    bdach committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    10ece0b View commit details
    Browse the repository at this point in the history