Increase tolerance in decoupling framed clock tests #6011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're starting to get a bit flaky, as seen in: https://github.com/ppy/osu-framework/pull/6009/checks?check_run_id=17249564046 https://github.com/ppy/osu-framework/pull/6009/checks?check_run_id=17249563269 30ms of leeway is enough to cover these, and then some (biggest gap seen so far was ~21ms).
peppy
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're starting to get a bit flaky, as seen in:
30ms of leeway is enough to cover these, and then some (biggest gap seen so far was ~21ms).