Fix race condition in ThreadedTaskScheduler when adding tasks #6014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
changed the title
smoogipoo
force-pushed
the
fix-threadedtaskscheduler-race-condition
branch
from
841d4c9
to
bd42383
Compare
|
Is there a reason the test coverage for this can't be committed? |
|
How? It's a race condition... It's just fails at some random point. |
|
We've added such tests to source in the past. Compare: |
|
Even if it's just run a few hundred times (and only fails one out of several runs), I think having the test around as a reference is valuable for any future manual testing. |
|
TIL. Added the test. |
peppy
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/ppy/osu/runs/17361055215#r0s1