Allow enabling computed mipmaps in LargeTextureStore
#6048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No testing whatsoever? |
|
Added 👌 |
peppy
requested changes
Nov 16, 2023
| [BackgroundDependencyLoader] | ||
| private void load(IRenderer renderer, GameHost host, Game game) | ||
| { | ||
| dependencies.CacheAs(new LargeTextureStore(renderer, host.CreateTextureLoaderStore(new NamespacedResourceStore<byte[]>(game.Resources, "Textures")), manualMipmaps: false)); |
There was a problem hiding this comment.
Setting manualMipamaps: true doesn't change anything in the test.
I'd hope the test shows the difference between the two.
There was a problem hiding this comment.
Setting manualMipamaps: true doesn't change anything in the test.
That's weird, for me the difference is very clear (I'm on D3D)
There was a problem hiding this comment.
May have been hot reload failing. But I'd also hope the test can be run in both modes. I don't want to have to change code each time I want to check a test.
There was a problem hiding this comment.
Will do. Was just trying to ensure it works for you and not a renderer issue or something.
peppy
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion.