Request READ_EXTERNAL_STORAGE permission on older android versions
#6071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documented (badly) in https://developer.android.com/reference/android/Manifest.permission#READ_MEDIA_IMAGES > For apps with a targetSdkVersion of Build.VERSION_CODES.S_V2 or lower, the READ_EXTERNAL_STORAGE permission is required, instead, to read image files. They actually meant to say "for apps that will run on Build.VERSION_CODES.S_V2 or lower [...]"
|
Was any testing done on this? I want to say I'm pretty sure I tested the original change on an android 7 device and saw nothing like what's being reported there. As much as I dislike android I would like to think they are still able to write accurate documentation. |
|
Tested on an Android 11 device. Current osu! and tests without the change show "No permissions requested" in system settings (file selector doesn't show any files). With the change, the storage permissions is available and granting it makes the file selector work. |
|
Can this come with an inline comment in the manifest at least then? We're likely never getting rid of that thing anyway but at least that would help explain things given that android docs cannot. |
Includes a note for future implementations of runtime permissions checks/requests. Only relevant for the framework, as consumers will use abstractions.
peppy
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in https://discord.com/channels/188630481301012481/1097318920991559880/1179849444032790589.
Regressed in #5973.
Since the
READ_EXTERNAL_STORAGEpermission is not declared, access to storage wouldn't work on older devices. The new permissions used in #5973 only work for newer devices.Documented (badly) in https://developer.android.com/reference/android/Manifest.permission#READ_MEDIA_IMAGES
They actually meant to say "for apps that will run on Build.VERSION_CODES.S_V2 or lower [...]"