New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup DrawNode
drawing methods
#6073
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
peppy
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine to my eye.
bdach
reviewed
Dec 4, 2023
bdach
changed the title
Cleanup DrawNode drawing methods
Cleanup Dec 4, 2023
DrawNode
drawing methods
bdach
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curious what people's thoughts are on this.
Right now, we have a dichotomy between the implementations of
Draw()
andDrawOpaqueInternal()
where one batches everything including children insideDraw()
but the other exposesDrawOpaqueInternalSubtree()
for this purpose.This results in other weirdness, like
Draw()
beingpublic
andDrawOpaqueInternal()
being protected. As a consumer of the framework, there is no way to correctly implementDrawOpaqueInternal()
if needing to draw a child, prior to this PR.My eventual goal is to be able to wrap both of these draw functions in some way that indicates to the renderer what
DrawNode
is currently being drawn, for example something like...This is a breaking change.
vNext
DrawNode.Draw()
has been madeprotected
In order to match the signature of
DrawOpaqueInternal()
,Draw()
has been madeprotected
.DrawNode
s which draw others from within themselves need to make use of helper methods: