Fix InputManager
including non-loaded direct children in input queue
#6101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeyBindingContainer
gets into a weird state when handling input while it's not loaded. Since it's not loaded,KeyBindings
would be null since it only gets populated inLoadComplete
, so no press/release events are propagated to children for the first key. However, the key gets stored inpressedInputKeys
, and later on, when the next key is pressed, the old key incorrectly becomes processed as a new binding as well, causing the double-press issue.KeyBindingContainer
was not supposed to enter the input queue if it's not fully loaded in the first place, but turns outInputManager
was incorrectly adding it (by bypassingShouldBeConsideredForInput
).