Fix insane joystick allocations overhead #6115
Conversation
|
Turns out this only affects tests. And I'm not even going to try to fix the rest of the issues (basically |
|
Turns out it doesn't only affect tests. I'm going to have to fix the rest of this mess... Will do that in separate PRs. |
| @@ -22,10 +21,17 @@ public class JoystickState | |||
| /// </summary> | |||
| internal readonly JoystickButton[] AxisDirectionButtons = new JoystickButton[MAX_AXES]; | |||
|
|
|||
| private readonly JoystickAxis[] axes = new JoystickAxis[MAX_AXES]; | |||
There was a problem hiding this comment.
I do wonder if this is worth the hassle. Like if GetAxes() is just a thin veneer over this array then you might as well expose it as public anyway and remove the method entirely. Heck all of the other input state classes do that.
Probably fine either way but I do wonder about your opinion.
There was a problem hiding this comment.
I'm fine with that, but the main reason I didn't is because when I've done so before, issue has been brought with the non-immutability nature of arrays. Hinted on this in the OP (the fact we're casting this to IEnumerable also causes enumerator overheads).
Dunno, I lean more towards "we're making a game engine, not a financial framework which needs to guard against users doing silly things at all costs". We've sacrificed performance (and time to fix that performance gap) due to being overly careful over the years and I'm not sure how worth it that is.
There was a problem hiding this comment.
I'll go with this for now as not to slow this down over trivialities but other input state classes already do raw arrays so /shrug
I'd love to remove that remaining enumerator but not sure on the best way. Open to advice:
osu-framework/osu.Framework/Input/StateChanges/JoystickAxisInput.cs
Lines 16 to 19 in 75ed421