Guard against potential usage of DrawablePool
without being added to hierarchy
#6136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has caught me twice to date. It still works roughly correctly, but won't initialise the pool to the correct default size, taking away the startup performance benefits of pooling.
Breaking changes
DrawablePool.Get()
wil now throw if theDrawablePool
did not begin loadPreviously the pool would return drawables correctly but it would not initialise the pool to correct default size, causing overheads on drawable retrieval (usually on update thread).