Add flaky test attribute and mark CanSeekForwardOnInterpolationFail as flaky
#6140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
reviewed
Jan 18, 2024
| @@ -156,7 +156,13 @@ public void NeverInterpolatesBackwardsOnInterpolationFail() | |||
| Assert.Greater(interpolatedCount, 10); | |||
| } | |||
|
|
|||
| // always failing on single-thread macOS CI, failing when test asserts interpolating.IsInterpolating = false | |||
There was a problem hiding this comment.
If it always fails, flaky probably won't work? It's only intended for intermittent failures.
There was a problem hiding this comment.
Well sometimes it passes (see current CI status), so I wasn't sure about fully ignoring it. But I could easily do so, and make the ignore macOS-only using Assert.Ignore. Will leave it to your call.
There was a problem hiding this comment.
Dunno, I read your comment "always failing" and made the assumption that was the case. Change the comment to "Intermittently failing" i guess
peppy
reviewed
Jan 18, 2024
peppy
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been failing for quite some time now.