Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix IBindableList.GetEnumerator() boxing and allocating" #6162

Merged
merged 2 commits into from Jan 31, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Jan 30, 2024

Android decided it didn't like this optimisation. Not exactly surprised given the track record we have with these sorts of tricky changes (something inside mono reeeeeally doesn't like interface level trickery).

Copy link
Member

@Susko3 Susko3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested to work fine with playing a beatmap on osu! when building Release.

@peppy peppy self-requested a review January 31, 2024 06:41
@peppy peppy merged commit 121d25c into master Jan 31, 2024
24 checks passed
@bdach bdach deleted the revert-6155-debox-ibindblelist-enumerator branch January 31, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Android version is unplayable
3 participants