Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to .NET 8 and C# 12 #6169

Merged
merged 11 commits into from Feb 5, 2024
Merged

Upgrade to .NET 8 and C# 12 #6169

merged 11 commits into from Feb 5, 2024

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Feb 2, 2024

Don't merge this yet. osu! may be updated to .NET 8 before osu!framework.

Upgrading to C# 12 is required because we use a few constructs that are no longer supported by newer SDKs on older C# versions.

I've tested this on iOS but not Android.

@smoogipoo smoogipoo changed the title Upgrade to .NET 8 Upgrade to .NET 8 and C# 12 Feb 2, 2024
@Susko3
Copy link
Member

Susko3 commented Feb 2, 2024

I've fixed some android inspections in #6171.

What remains is the obsoleted APIs in AndroidGameView. Those can be ignored (with #pragma) for now.

But the targetSdkVersion needs addressing, for every android project:

The TargetFrameworkVersion (Android API level 34) is higher than the targetSdkVersion (33). Please increase the android:targetSdkVersion in the AndroidManifest.xml so that the API levels match.

@bdach
Copy link
Collaborator

bdach commented Feb 5, 2024

Android seems to launch fine, at least whatever's runnable framework-side (visual tests & sample game).

@peppy peppy self-requested a review February 5, 2024 13:07
@peppy peppy merged commit 6633f5e into ppy:master Feb 5, 2024
21 checks passed
andy840119 added a commit to andy840119/osu-framework-microphone that referenced this pull request Feb 19, 2024
Copy the ci.yml in the osu-framework.
see: ppy/osu-framework#6169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET MAUI 6 has been unsupported for some time (preventing iOS 17 support)
4 participants