Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new MD5/SHA.HashData(Stream) overload #6177

Merged
merged 2 commits into from Feb 9, 2024
Merged

Use new MD5/SHA.HashData(Stream) overload #6177

merged 2 commits into from Feb 9, 2024

Conversation

turbedi
Copy link
Contributor

@turbedi turbedi commented Feb 8, 2024

Benchmark:

Method Mean Error StdDev Gen0 Allocated
StreamMD5 2.645 μs 0.0151 μs 0.0134 μs 0.0687 296 B
StreamMD5_New 2.499 μs 0.0105 μs 0.0093 μs 0.0381 160 B
StreamSHA 1.649 μs 0.0132 μs 0.0124 μs 0.0935 392 B
StreamSHA_New 1.568 μs 0.0128 μs 0.0114 μs 0.0572 240 B

@peppy peppy self-requested a review February 9, 2024 03:17
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Feb 9, 2024
@peppy peppy merged commit 0e88708 into ppy:master Feb 9, 2024
21 checks passed
@turbedi turbedi deleted the HashData_Stream branch February 9, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@turbedi @peppy