Use ThrowHelper methods in more places

[turbedi]

• Might help with Hot paths should not contain throw to promote inlining #3470

ObjectDisposedException.ThrowIf(), ArgumentException.ThrowIfNullOrEmpty() and the ArgumentOutOfRangeException methods have been introduced in .NET 7/8

[Susko3]

Seems ok but some error messages have changed for the worse.

[Susko3]

Just noting that maxSize no will longer appear in the error message.

master:

System.ArgumentOutOfRangeException : Must be less than maxSize. (Parameter 'minSize')

This PR:

System.ArgumentOutOfRangeException : minSize ('20') must be less than or equal to '10'. (Parameter 'minSize')
Actual value was 20.

[Susko3]

See other comment about maxValue/maxSize no longer appearing in the error message. Same applies for the other usage of ThrowIfGreaterThan() in this file.

[turbedi]

I've addressed some of the comments. Should I also revert all usages of ThrowIfGreaterThan() to retain the max value in the error message, or is it fine like that?

[frenzibyte]

Related: #3470

[smoogipoo]

The other path I can suggest is to make an ExceptionUtils.ValidateRange(). Otherwise, I'm weakly okay with the change in messaging but I'd want other reviews.

[frenzibyte]

I personally don't feel the exception message matters that much. Sure it might be a little bit cryptic, but the "must be greater than"/"must be lower than" is already giving it out I think.

[bdach]

My view on the ThrowIfGreaterThan() thing is that I'd be fine with the max value not being printed only if it's a constant. So in cases where the max value isn't statically known just by looking at the direct call site it should print the max in the exception message.

Which this does, so I'm fine with this. The fact that it doesn't print the name of the other value feels whatever.

[turbedi]

All comments have been addressed.