Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IL3000 warning on Android #6300

Merged
merged 1 commit into from
May 24, 2024
Merged

Fix IL3000 warning on Android #6300

merged 1 commit into from
May 24, 2024

Conversation

Susko3
Copy link
Member

@Susko3 Susko3 commented May 23, 2024

https://learn.microsoft.com/en-us/dotnet/core/deploying/single-file/warnings/il3000

osu-framework\osu.Framework.Tests\IO\TestOnlineStore.cs(102,35): warning IL3000: 'System.Reflection.Assembly.Location' always returns an empty string for assemblies embedded in a single-file app. If the path to the app directory is needed, consider calling 'System.AppContext.BaseDirectory'.

Likely to show on embedded mobile platforms like iOS and Android.

> osu-framework\osu.Framework.Tests\IO\TestOnlineStore.cs(102,35): warning IL3000: 'System.Reflection.Assembly.Location' always returns an empty string for assemblies embedded in a single-file app. If the path to the app directory is needed, consider calling 'System.AppContext.BaseDirectory'.
Copy link
Sponsor Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this is only changed in test code I think it's fine without too much considerations.

@peppy peppy merged commit efb30d9 into ppy:master May 24, 2024
21 checks passed
@Susko3 Susko3 deleted the fix-IL3000 branch May 24, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants