Mark FindClosestParent<T>() callers as possibly null-returning
#6303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
force-pushed
the
find-closest-parent-null
branch
from
3f4ec4f
to
64e95e6
Compare
smoogipoo
reviewed
May 27, 2024
smoogipoo
reviewed
May 29, 2024
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
smoogipoo
previously approved these changes
May 29, 2024
smoogipoo
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC.
In particular, the important callers in question here are
GetContainingInputManager()andGetContainingFocusManager(). The hope is that with proper nullability annotations, #6302 would have been caught by static analysis.When preparing this, I saw that about 20% of calls to
GetContainingFocusManager()already handled null, and the rest did not. Make of that what you will.Game-side branch for preview of impact: https://github.com/ppy/osu/compare/master...bdach:osu:find-closest-parent-null-adjustments?expand=1