New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ScrollContainer lagging behind by one frame #801

Merged
merged 2 commits into from Jun 8, 2017

Conversation

3 participants
@default0
Contributor

default0 commented Jun 7, 2017

The internal size the ScrollContainer used to make decisions about
the scroll range, scrollbar size, etc. was outdated by one frame
because it was updated before its children.

default0 and others added some commits Jun 7, 2017

Fix ScrollContainer lagging behind by one frame
The internal size the ScrollContainer used to make decisions about
the scroll range, scrollbar size, etc. was outdated by one frame
because it was updated before its children.
@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Jun 8, 2017

Member

👍 fixes chat scrollToEnd too

Member

peppy commented Jun 8, 2017

👍 fixes chat scrollToEnd too

@peppy

peppy approved these changes Jun 8, 2017

@peppy peppy merged commit a897845 into ppy:master Jun 8, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Tom94

This comment has been minimized.

Show comment
Hide comment
@Tom94

Tom94 Jun 8, 2017

Collaborator
Collaborator

Tom94 commented Jun 8, 2017

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Jun 8, 2017

Member

Mutual benefit; not complaining 🏎

Member

peppy commented Jun 8, 2017

Mutual benefit; not complaining 🏎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment