Fix ScrollContainer lagging behind by one frame #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internal size the ScrollContainer used to make decisions about the scroll range, scrollbar size, etc. was outdated by one frame because it was updated before its children.
|
👍 fixes chat scrollToEnd too |
peppy
approved these changes
Jun 8, 2017
|
Fixing scroll to end was the point. Only for his game, not osu. ;)
|
|
Mutual benefit; not complaining 🏎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal size the ScrollContainer used to make decisions about
the scroll range, scrollbar size, etc. was outdated by one frame
because it was updated before its children.