Fix deadlock on linux hosts when exiting the game #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bass should be freed after completely exiting the audio thread. |
peppy
approved these changes
Jun 21, 2017
peppy
changed the title
|
Please write PR titles better "Fix deadlock on linux hosts when exiting the game" |
|
@paparony03, isn't if you call Exit next actions with AudioManager just wouldn't be processed, they will go in queue and stay until gc destroy it, call to base.Exit should solve this. Also Exit for AudioManager's thread called from osu code only at the end(with another threads destruction). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe program and linux's sound subsystem share resource and linux cannot destroy program until you free it explicitly, and eventually you get timeout from c# runtime. Fix #315