Implement NonNullableBindable #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
smoogipoo
approved these changes
Jul 19, 2017
|
Needs XML docs. We really need to stop merging non-documented stuff into
the framework. :/
…On 19 Jul 2017 11:26 a.m., "Dean Herbert" ***@***.***> wrote:
Merged #912 <#912>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#912 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEshB5b-tudwFIBUXXOPdOlnLe3vRIOHks5sPb3EgaJpZM4OcOr_>
.
|
|
The whole of bindables needs xmldoc, I noted this while making this change. It's on my list. |
|
Still, I think we need to enforce at least 100% docs on new code and
(probably also makes sense to enforce anything that is refactored to be
doc'd). I think this will already go a long way over time.
…On 19 Jul 2017 11:36 a.m., "Dean Herbert" ***@***.***> wrote:
The whole of bindables needs xmldoc, I noted this while making this change.
It's on my list.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#912 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEshBwtcPPg4fyy3qexyqlR51eSLfBkCks5sPcAbgaJpZM4OcOr_>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bindable which can never take on a null value.