Fix incorrect client hash #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
reviewed
Jan 30, 2024
| // The token is 82 chars long, and the clientHash is the first 32 of those. | ||
| // See: https://github.com/ppy/osu-web/blob/7be19a0fe0c9fa2f686e4bb686dbc8e9bf7bcf84/app/Libraries/ClientCheck.php#L92 | ||
| if (versionHash?.Length >= 82) | ||
| versionHash = versionHash.Substring(versionHash.Length - 82, 32); |
There was a problem hiding this comment.
What's with the subtraction? If the client hash is the first 32 chars of this, then why is the first argument not... just 0?
There was a problem hiding this comment.
The 82-length portion is actually at the end of a much longer string.
Actually now that I mention it, I should probably make sure this is only sent on the first request otherwise this is quite a lot of data to send in a realtime system.
There was a problem hiding this comment.
Should be fine so long as SignalR doesn't fallback to one of the polling transports. If it does we can fix that when we come to it.
bdach
approved these changes
Jan 30, 2024
peppy
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client will eventually send the correct hash as it does for osu-web, for this server too.