Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible lack of validation of invalid mod combos #10424

Open
0xallie opened this issue Jul 31, 2023 · 3 comments
Open

Possible lack of validation of invalid mod combos #10424

0xallie opened this issue Jul 31, 2023 · 3 comments

Comments

@0xallie
Copy link

0xallie commented Jul 31, 2023

I modified osu!lazer to allow any mod combos to see what happens. I only tested this on dev.ppy.sh for obvious reasons, which doesn't seem to actually rank any scores, but the fact that this shows up warrants a check to make sure the prod server isn't accepting such scores.

Screenshot of my recent play on dev.ppy.sh. The map is Harumachi Clover by Hanasaka Yui(CV: M.A.O), and the score is an SS with 100% accuracy. Mods used are NF, EZ, HD, HR, RX, HT, NC, FL, SO, AP, PF.
@peppy
Copy link
Sponsor Member

peppy commented Jul 31, 2023

This will be covered by anti-cheat external to osu-web. Adding checks in osu-web could be considered optional.

Will leave it up to the team's discretion whether to consider or close.

@cl8n
Copy link
Member

cl8n commented Aug 7, 2023

there is already code to validate mod combos but some of it (assertValidExclusivity) is only used for multiplayer currently. at a glance I'm not sure why solo and multiplayer differ here

@nanaya
Copy link
Collaborator

nanaya commented Aug 7, 2023

it's mainly for room validation, not score

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants