Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert costs to integer before validating #1968

Closed
notbakaneko opened this issue Dec 12, 2017 · 0 comments · Fixed by #1971
Closed

Convert costs to integer before validating #1968

notbakaneko opened this issue Dec 12, 2017 · 0 comments · Fixed by #1971
Assignees
@notbakaneko
Labels
area:store
Milestone
December 2017

Comments

@notbakaneko
Copy link
Collaborator

Because floating point shenanigans

>>> (10.00 + 1.88) === 11.88
=> false

>>> (10.00 + 1.88) * 100 === 11.88 * 100
=> true

:trollface:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@notbakaneko notbakaneko

Labels
area:store
Projects
None yet
Milestone
December 2017
Development

Successfully merging a pull request may close this issue.

Compare money values with integers instead of floats. notbakaneko/osu-web
2 participants
@peppy @notbakaneko