Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image slicing and html #2060

Closed
nanaya opened this issue Dec 21, 2017 · 2 comments
Closed

Image slicing and html #2060

nanaya opened this issue Dec 21, 2017 · 2 comments

Comments

@nanaya
Copy link
Collaborator

nanaya commented Dec 21, 2017

Old site uses transitional doctype and thus triggers browsers' quirks/almost standards mode which <br> (and everything but text) ignores line height and has dimension of 0x0.

Standard mode used by new site has different behavior where <br> (and everything else) has minimum height of the container's line height. This caused image slicing where the image height is less than line height having gap in them.

Comparison:

One possible solution is to add a new tag which wraps the images in a container with line-height of 0 (and then the old site will show the tag as is, unparsed :D ).

The other is just telling people to have image slice with enough height.

(talking about this)

@Hughp135
Copy link
Contributor

Hughp135 commented Apr 6, 2018

Another option would be to make everything display as block. Float images left, put text sections into paragraph tags, and everything else into div's, etc.

@nanaya
Copy link
Collaborator Author

nanaya commented Mar 10, 2023

Superseded by #8751.

@nanaya nanaya closed this as not planned Won't fix, can't repro, duplicate, stale Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants